Founder ownership of 100% will prevent Founders from receiving any tokens at all

[code423n4]

Lines of code

https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/token/Token.sol#L151-L157

Vulnerability details

Impact

When the total founder ownership is 100%, all NFT tokens which are minted will be automatically minted for the founders. However, as token.mint() will constantly increase tokenID, unbounded gas consumption occurs which will cause the external call to revert due to exceeding block gas limits, thereby pausing the auction contract without the founders receiving any NFTs. Therefore, the auction will only properly work once the founder's claim has expired, with founders not receiving a single NFT.

I believe medium severity is suitable as this issue breaks a pretty significant selling point of the protocol however requires that the founders setup the governance with 100% initial ownership

Proof of Concept

1. Alice deploys the new governance protocol and sets founderPct = 100
2. Alice starts the auction by calling unpause() in Auction.sol
3. _createAuction() calls token.mint() which starts an infinite loop and reverts
4. Due to the try/catch statement, the contract is paused and no auction can start

Tools Used

VS Code

Recommended Mitigation Steps

Add a check to make sure that founder ownership does not reach 100% e.g.
In _addFounders() from Token.sol add a greater or equal than sign:

if ((totalOwnership += uint8(founderPct)) >= 100) revert INVALID_FOUNDER_OWNERSHIP();

[GalloDaSballo]

Dup of #347