React #1
Open
React #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server serves: 1. The `./public` folder as the document root. 2. The `/scripts/env.js` returns object of environment variable(s).
Cannot directly use API server (same origin policy problem). Proxy the API to local folder "/api" to avoid problem.
Use webpack to bundle and parse javascript, jsx into bundle.js. Prepare for isomorphic javascript structure.
Added webpack to dependency
Separated components into different jsx files. Added 1 dummy page component "AboutPage". Use ReactRouter for browser routing.
Use browser-request instead of jQuery.ajax for RESTful API call. Road to use 'request' in nodejs for server side HTTP request and isomorphic javascript frontend.
It should be a common utility.
Prevent error loading subfolders
Use render function in route handler to trigger route action. Every route handler should represent a special set of routing logic.
Prevent manual overriding of env.js in file system.
1. Use gulp to handle js, css generation 2. Use BrowserSync for development 3. Move the api proxy from server.js to gulpfiles and only start when `npm run dev`
`gulp` has already covered the development server environment.
Always serve index.html if no file is found.
Do process.exit(1) if env.js is not generated correctly or if api forward server couldn't start.
All routes extends PageMaster and only render the main contents themselves.
Seems header has to be directly under the layout class for responsive menu to work properly. Hence changed.
Removed NewsListTitle. Easier to maintain. Also simplified the props in NewsListStore. Now empty "publisher_code" means to show all news.
Smaller font.
Put the route action back
1. Moved PageMaster code to App. 2. Renamed PageNotFound to NotFoundPage (align with other pages).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Far from functional, but this is the work I've done so far.