Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new CGPreFlightScreenCaptureAccess and CGRequestScreenCaptureAccess API on MacOS 11+ #35

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

DanielMcAssey
Copy link
Contributor

@DanielMcAssey DanielMcAssey commented Feb 4, 2022

MacOS 11 introduces 2 new APIs for requesting and checking screen capture access.

https://developer.apple.com/documentation/coregraphics/3656523-cgpreflightscreencaptureaccess

And

https://developer.apple.com/documentation/coregraphics/3656524-cgrequestscreencaptureaccess

The documentation says 10.15+ but its wrong and it only seems to work on 11+

@codebytere codebytere self-requested a review February 7, 2022 20:53
@codebytere
Copy link
Owner

@DanielMcAssey lint failure can be fixed by running npm run format - thanks for adding this! it looks good and we can merge it once the lint is ironed out :)

@DanielMcAssey
Copy link
Contributor Author

@codebytere thank you! All done, hopefully all lint checks pass

@codebytere codebytere merged commit 51a2739 into codebytere:main Feb 10, 2022
@DanielMcAssey DanielMcAssey deleted the use-new-screen-capture-api branch February 10, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants