-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playwright)/new api: .clear()
, .blur()
, .focus()
#3665
Merged
DavertMik
merged 35 commits into
codeceptjs:3.x
from
EgorBodnar:feat(playwright)/new_api
Jun 4, 2023
Merged
feat(playwright)/new api: .clear()
, .blur()
, .focus()
#3665
DavertMik
merged 35 commits into
codeceptjs:3.x
from
EgorBodnar:feat(playwright)/new_api
Jun 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arhell
approved these changes
May 16, 2023
kobenguyent
approved these changes
May 17, 2023
kobenguyent
reviewed
May 17, 2023
EgorBodnar
commented
May 17, 2023
peterngtr
reviewed
May 19, 2023
DavertMik
requested changes
May 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the thing. Playwright introduced clear
only in recent releases, while we had clearField (not with the best implementation) from the very beginning 😃
But now please replace clearField
implementation with a native one and I'm merging
…elper definitions
…re merged without generating documentation.
…ality in case of new codeceptjs version usage with old playwright
…e of new codeceptjs version usage with old playwright
DavertMik
approved these changes
Jun 4, 2023
Thank you so much! |
.clear()
, .blur()
, .focus()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
The reason for the PR is the Integration of the new Playwright API into CodeceptJS and the bumping Playwright version to
1.32.3
.A list of the new Playwright API, which is important to the CodeceptJS framework, but has not yet been included:
As part of this PR added implementations of these methods in Codeceptjs.
Bringing the name of options to a general form: opts vs options
Added tests, HTML forms for tests and documentation:
I.focus()
I.blur()
I.clearField()
modified | oldI.clearField()
In fact, didn't clean the field, but replaced its value with an empty string. It doesn't always work. So it's better to use the new Playwright API (.clear
) for this. Backward compatibility is preserved for those who use the old version of the Playwright.Created feature request [FEATURE REQUEST](playwright) migrate locators from
ElementHandle
toLocator
. #3677 because all the new Playwright functionality is tied to the Locator and it is impossible to use the new Playwright API for elements found through the ElementHandle only if it does not match withdevtools-protocol
API.Added temporary solution function getXPathForElement(elementHandle) to use like a bridge between old ElementHandle and new Locator
Applicable helpers:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)