Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

chore(security/deps): update and pin dependencies #372

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

drazisil-codecov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #372 (1531a0d) into master (f864f3b) will decrease coverage by 1.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   82.76%   80.85%   -1.92%     
==========================================
  Files          23       23              
  Lines         383      397      +14     
  Branches       96      110      +14     
==========================================
+ Hits          317      321       +4     
- Misses         53       63      +10     
  Partials       13       13              
Impacted Files Coverage Δ
lib/codecov.js 67.12% <0.00%> (-3.13%) ⬇️
lib/services/localGit.js 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f864f3b...1531a0d. Read the comment docs.

@drazisil-codecov
Copy link
Contributor Author

drazisil-codecov commented Oct 25, 2021

Codecov Report

Merging #372 (1531a0d) into master (f864f3b) will decrease coverage by 1.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   82.76%   80.85%   -1.92%     
==========================================
  Files          23       23              
  Lines         383      397      +14     
  Branches       96      110      +14     
==========================================
+ Hits          317      321       +4     
- Misses         53       63      +10     
  Partials       13       13              

Impacted Files Coverage Δ
lib/codecov.js 67.12% <0.00%> (-3.13%) ⬇️
lib/services/localGit.js 100.00% <0.00%> (+11.11%) ⬆️
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f864f3b...1531a0d. Read the comment docs.

I'm glad we are depreciating this version. I don't want to investigate how updating the dependencies is causing coverage to drop.

@thomasrockhu-codecov , @eliatcodecov , @mitchell-codecov Should we push a new package that is an empty shell saying this is deprecated so folks don't continue to pull it? (as long as they are pinned, it shouldn't break anybody . We can even make it a major release to completely cover the bases.

@mitchell-codecov
Copy link

We should look into deprecating the package through the mechanisms available through npm. I believe there is a package deprecation feature we can use.

@drazisil-codecov
Copy link
Contributor Author

We should look into deprecating the package through the mechanisms available through npm. I believe there is a package deprecation feature we can use.

You are correct. Shows how often I touch packages on NPM. :)

@drazisil-codecov drazisil-codecov merged commit 827d4e1 into master Oct 25, 2021
@drazisil-codecov drazisil-codecov deleted the security-updates branch October 25, 2021 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants