Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update composer.json so that packagist updates the package again #21

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jan 19, 2018

Currently Packagist is not auto updating this package, because its composer.json is not approved by Packagist. See https://packagist.org/packages/codefog/contao-social_images - the 3.5.0 tag is missing for example.

Packagist now disallows the deprecated usage of LGPL-3.0+ for the license. Instead you have to use LGPL-3.0-or-later.

This is pretty ridiculous of packagist to be honest. I suspect there are many, many packages that now aren't auto updated anymore, since they use LGPL-3.0+. I have to update a lot of my packages too -_-

@qzminski
Copy link
Member

Wuuut really? Where did they announce that? 🤔

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 19, 2018

I don't know if they ever did that. If you go to https://packagist.org/packages/codefog/contao-social_images while being logged in to your packagist account, there should be a pop up telling you the problems with the composer.json.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 19, 2018

According to https://twitter.com/seldaek/status/954333243557412869 Packagist is supposed to send you an email, when the update first fails. I haven't received any such emails though, neither did other devs I know.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 20, 2018

Could you merge this please? :) Then the 3.5.0 tag should be published to packagist automatically. No new release tag needs to be created just for this.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 21, 2018

composer/packagist#858

@qzminski qzminski added the bug label Jan 22, 2018
@qzminski qzminski changed the base branch from master to hotfix/3.5.1 January 22, 2018 08:08
@qzminski qzminski merged commit 3c8d6eb into codefog:hotfix/3.5.1 Jan 22, 2018
@qzminski
Copy link
Member

I have merged it to 3.5.1, thanks! 👍

@fritzmg fritzmg deleted the patch-3 branch January 22, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants