Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consumer] resize/scale logo to fit in UI #78

Open
levifelling opened this issue Jun 7, 2016 · 3 comments
Open

[Consumer] resize/scale logo to fit in UI #78

levifelling opened this issue Jun 7, 2016 · 3 comments
Assignees
Milestone

Comments

@levifelling
Copy link
Contributor

As discussed at 6/6 meetup, API will return logo in a predefined aspect ratio client side will need to scale image to correct size for display.

@Lowell20
Copy link
Contributor

Lowell20 commented Jun 7, 2016

I will allow the upload of any aspect ratio but will scale the image to 3:2 aspect ratio.
This might create less than desirable results but we can mediate this problem manually for now, until we decide on a better solution.

@Lowell20
Copy link
Contributor

Lowell20 commented Jun 7, 2016

I would like to setup a minimum image size requirements to avoid problems with up-sizing. What is the minimum size image you would like to see in the consumer?

@AnthonyAstige AnthonyAstige added this to the MVP milestone Jun 7, 2016
@AnthonyAstige
Copy link
Member

I will allow the upload of any aspect ratio but will scale the image to 3:2 aspect ratio.
This might create less than desirable results but we can mediate this problem manually for now, until we decide on a better solution.

Sounds good so long as any original non-3:2-aspected images are stored in Drupal (so an admin can go deal with it manually), this sounds good to me.

levifelling added a commit that referenced this issue Jun 14, 2016
[Consumer] #78 Locked the aspect ratio of the logo so that it resizes…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants