Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-4769 - repo install + create git_source #10

Merged
merged 9 commits into from
Jun 22, 2021
Merged

CR-4769 - repo install + create git_source #10

merged 9 commits into from
Jun 22, 2021

Conversation

noam-codefresh
Copy link
Contributor

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jun 21, 2021
go.mod Outdated Show resolved Hide resolved

fullResPath := insFs.Join(insFs.Root(), resPath)
if err = createApp(ctx, insCloneOpts, runtimeName, gsName, insCloneOpts.URL()+fullResPath, application.AppTypeDirectory, runtimeName); err != nil {
return fmt.Errorf("failed to create git-source: %w", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if some of the steps failed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, each autopilot command (bootstrap, project create, 3 * app create + 1 final app create for the git-source) performs its own clone-persist-commit-push. So a failure in a later step will still leave the GitOps repo with some data in it, and the cluster with some state of the runtime.
We thought about using a single FS for all the commands, and change the autopilot so it will run in a mode that just uses an existing local git repo, with pull-persist-commit only, and then just manually push at the end. This way the GitOps repo will either contain all the manifests, or none.

@noam-codefresh noam-codefresh changed the title wip CR-4769 - repo install + create git_source Jun 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #10 (57ae20e) into main (8290bc1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   25.13%   25.13%           
=======================================
  Files           1        1           
  Lines         187      187           
=======================================
  Hits           47       47           
  Misses        134      134           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8290bc1...57ae20e. Read the comment docs.

@noam-codefresh noam-codefresh marked this pull request as ready for review June 22, 2021 13:00
@noam-codefresh noam-codefresh merged commit 5acfab8 into main Jun 22, 2021
@noam-codefresh noam-codefresh deleted the CR-4769 branch June 22, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants