-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR-4769 - repo install + create git_source #10
Conversation
|
||
fullResPath := insFs.Join(insFs.Root(), resPath) | ||
if err = createApp(ctx, insCloneOpts, runtimeName, gsName, insCloneOpts.URL()+fullResPath, application.AppTypeDirectory, runtimeName); err != nil { | ||
return fmt.Errorf("failed to create git-source: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if some of the steps failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, each autopilot command (bootstrap, project create, 3 * app create + 1 final app create for the git-source) performs its own clone-persist-commit-push. So a failure in a later step will still leave the GitOps repo with some data in it, and the cluster with some state of the runtime.
We thought about using a single FS for all the commands, and change the autopilot so it will run in a mode that just uses an existing local git repo, with pull-persist-commit only, and then just manually push at the end. This way the GitOps repo will either contain all the manifests, or none.
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 25.13% 25.13%
=======================================
Files 1 1
Lines 187 187
=======================================
Hits 47 47
Misses 134 134
Partials 6 6 Continue to review full report at Codecov.
|
No description provided.