CR-15313-invalid-tunnel-url #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-codefresh
requested review from
roi-codefresh,
danielm-codefresh,
pasha-codefresh,
ziv-codefresh and
itai-codefresh
as code owners
noam-codefresh
commented
Nov 6, 2022
| "Installing demo resources": strconv.FormatBool(installationOpts.InstallDemoResources), | ||
| } | ||
|
|
||
| if installationOpts.AccessMode == platmodel.AccessModeTunnel { |
There was a problem hiding this comment.
display the correct summary
noam-codefresh
commented
Nov 6, 2022
| @@ -339,6 +329,14 @@ func runtimeInstallCommandPreRunHandler(cmd *cobra.Command, opts *RuntimeInstall | |||
| if opts.AccessMode == platmodel.AccessModeTunnel { | |||
| handleCliStep(reporter.InstallStepPreCheckEnsureIngressClass, "-skipped (ingressless)-", err, true, false) | |||
| handleCliStep(reporter.InstallStepPreCheckEnsureIngressHost, "-skipped (ingressless)-", err, true, false) | |||
| opts.featuresToInstall = append(opts.featuresToInstall, runtime.InstallFeatureIngressless) | |||
There was a problem hiding this comment.
create tunnel ingressHost after runtimeName was supplied by user
noam-codefresh
commented
Nov 6, 2022
| @@ -387,6 +385,10 @@ func runtimeInstallCommandPreRunHandler(cmd *cobra.Command, opts *RuntimeInstall | |||
| log.G(ctx).Infof("using repo '%s' as shared config repo for this account", sharedConfigRepo) | |||
| } | |||
|
|
|||
| if opts.runtimeDef == "" { | |||
There was a problem hiding this comment.
just feels better located in here
daniel-codefresh
approved these changes
Nov 6, 2022
danielm-codefresh
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.