Add max file upload argument to test-reporting step #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
commented
Sep 5, 2024
| "image_tag": { | ||
| "type": "string", | ||
| "description": "The version of test reporting image", | ||
| "default": "1.2.0" |
There was a problem hiding this comment.
self-reminder: make sure the cf-docker-test-reporting:1.2.0 image is published before merging this PR.
vadim-kharin-codefresh
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Max File Upload is currently hardcoded to 1000MB which can sometimes not be enough in certain circumstances.
Why
Sometimes the upload can be over 1000MB which makes the step fail. Making it an argument allows users to specify the upload limit so it can be increased. It also allows users to reduce the value to ensure they don't upload too much by mistake.
Notes
I noticed that the docker image tag used on this step is ~4 years old so updating to my new tag includes some other changes to the
cf-docker-test-reportingimage. I've addedcf_api_retriesandreport_patharguments as they were added to the docker test reporting executable. I've also added theimage_tagargument as an escape hatch just in case it's necessary to target a specific image tag in the future.Testing
I've tested this locally against a pre-release build of the docker image and it works as expected.