Fix fail_fast pipeline attribute propagation

codefresh-io · Apr 22, 2021 · 70a34f7 · 70a34f7
1 parent 515053e
commit 70a34f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/client/pipeline.go b/client/pipeline.go
@@ -81,7 +81,7 @@ type Spec struct {
 	Steps              *Steps                   `json:"steps,omitempty"`
 	Stages             *Stages                  `json:"stages,omitempty"`
 	Mode               string                   `json:"mode,omitempty"`
-	FailFast           bool                     `json:"fail_fast,omitempty"`
+	FailFast           *bool                    `json:"fail_fast,omitempty"`
 	RuntimeEnvironment RuntimeEnvironment       `json:"runtimeEnvironment,omitempty"`
 	TerminationPolicy  []map[string]interface{} `json:"terminationPolicy,omitempty"`
 	Hooks              *Hooks                   `json:"hooks,omitempty"`

diff --git a/codefresh/resource_pipeline.go b/codefresh/resource_pipeline.go
@@ -747,7 +747,10 @@ func extractSpecAttributesFromOriginalYamlString(originalYamlString string, pipe
 		case "mode":
 			pipeline.Spec.Mode = item.Value.(string)
 		case "fail_fast":
-			pipeline.Spec.FailFast = item.Value.(bool)
+			ff, ok := item.Value.(bool)
+			if ok {
+				pipeline.Spec.FailFast = &ff
+			}
 		default:
 			log.Printf("Unsupported entry %s", key)
 		}