remove client.token and update docs for the resource

codefresh-io · Feb 22, 2024 · 9d011e1 · 9d011e1
1 parent 3d5f6d6
commit 9d011e1
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/codefresh/internal/schemautil/validation.go b/codefresh/internal/schemautil/validation.go
@@ -89,4 +89,4 @@ func (o *ValidationOptions) setSummary(summary string) *ValidationOptions {
 func (o *ValidationOptions) setDetailFormat(detailFormat string) *ValidationOptions {
 	o.detailFormat = detailFormat
 	return o
-}
+}
diff --git a/codefresh/resource_api_key.go b/codefresh/resource_api_key.go
@@ -94,10 +94,8 @@ func resourceApiKeyCreate(d *schema.ResourceData, meta interface{}) error {
 		return err
 	}
 
-	client.Token = resp
-
 	// Codefresh tokens are in the form xxxxxxxxxxxx.xxxxxxxxx the first half serves as the id
-	d.SetId(strings.Split(client.Token,".")[0])
+	d.SetId(strings.Split(resp, ".")[0])
 
 	return nil
 }
@@ -118,7 +116,6 @@ func resourceApiKeyRead(d *schema.ResourceData, meta interface{}) error {
 		return errors.New("[ERROR] Can't read API Key. Token is empty.")
 	}
 
-
 	apiKey, err := client.GetAPIKey(keyID)
 	if err != nil {
 		return err

diff --git a/codefresh/resource_pipeline_test.go b/codefresh/resource_pipeline_test.go
@@ -532,8 +532,8 @@ func TestAccCodefreshPipeline_CronTriggersInvalid(t *testing.T) {
 	var pipeline cfclient.Pipeline
 
 	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
-		Providers:    testAccProviders,
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccCodefreshPipelineBasicConfigCronTriggers(

diff --git a/docs/resources/api_key.md b/docs/resources/api_key.md
@@ -9,8 +9,8 @@ description: |-
 
 Manages an API Key tied to an Account and a User.
 
-terraform-provider-codefresh itself uses an API key, passed as provider's attribute, but it's possible to use that API Key to generate a new one.  
-
+terraform-provider-codefresh itself uses an API key, passed as provider's attribute, but it's possible to use that API Key to generate a new one. 
+This resource requires Codefresh system admin permissions, hence is relevant for on-prem deployments of Codefresh only.
 
 
 ## Example usage

diff --git a/templates/resources/api_key.md.tmpl b/templates/resources/api_key.md.tmpl
@@ -9,8 +9,8 @@ description: |-
 
 {{ .Description | trimspace }}
 
-{{ .ProviderName }} itself uses an API key, passed as provider's attribute, but it's possible to use that API Key to generate a new one.  
-
+{{ .ProviderName }} itself uses an API key, passed as provider's attribute, but it's possible to use that API Key to generate a new one. 
+This resource requires Codefresh system admin permissions, hence is relevant for on-prem deployments of Codefresh only.
 
 
 ## Example usage