Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitops abac rules #119

Merged
merged 14 commits into from
Jun 30, 2023
Merged

gitops abac rules #119

merged 14 commits into from
Jun 30, 2023

Conversation

andrii-codefresh
Copy link
Collaborator

@andrii-codefresh andrii-codefresh commented Jun 16, 2023

What

  • Add Gitops ABAC Rule resource

Why

For creating rules for gitops entities

Notes

Checklist

@github-actions github-actions bot added the docs label Jun 16, 2023
errors in resource_abac_rules_test.go, main.tf

.terraformrc
provider_installation {
    dev_overrides {
        "codefresh-io/codefresh" = "~/go/bin"
    }
    direct {}
}
@andrii-codefresh
Copy link
Collaborator Author

/test

2 similar comments
@korenyoni
Copy link
Contributor

/test

@korenyoni
Copy link
Contributor

/test

@denis-codefresh
Copy link
Collaborator

/test

2 similar comments
@korenyoni
Copy link
Contributor

/test

@korenyoni
Copy link
Contributor

/test

@andrii-codefresh
Copy link
Collaborator Author

/test

1 similar comment
@andrii-codefresh
Copy link
Collaborator Author

/test

@andrii-codefresh
Copy link
Collaborator Author

/test

@andrii-codefresh
Copy link
Collaborator Author

/test

Copy link
Contributor

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please fill in PR details

@korenyoni korenyoni added the enhancement New feature or request label Jun 29, 2023
@andrii-codefresh andrii-codefresh merged commit ab97b85 into master Jun 30, 2023
@korenyoni korenyoni deleted the CR-16391-abac-rules branch August 10, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants