-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitops abac rules #119
Merged
Merged
gitops abac rules #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-codefresh
requested review from
a team,
yaroslav-codefresh and
denis-codefresh
as code owners
June 16, 2023 11:15
…l-running provider
errors in resource_abac_rules_test.go, main.tf .terraformrc provider_installation { dev_overrides { "codefresh-io/codefresh" = "~/go/bin" } direct {} }
/test |
2 similar comments
/test |
/test |
/test |
2 similar comments
/test |
/test |
/test |
1 similar comment
/test |
/test |
denis-codefresh
approved these changes
Jun 29, 2023
/test |
korenyoni
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please fill in PR details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
For creating rules for gitops entities
Notes
Checklist
/test
comment will be ignored by the CI trigger unless it is made by a repo admin or collaborator.