Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Schema Validation Overhaul #128

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

korenyoni
Copy link
Contributor

@korenyoni korenyoni commented Oct 16, 2023

What

  • Overhaul schema validation by adding internal/schemautils and package
  • Overhaul general utils pattern by removing utils.go adding internal/datautils.go
  • Rename and move client package to codefresh.cfclient
  • Ensure plan-time CRON validation for codefresh_pipeline matches current API constraints, while maintaining backwards compatibility for the deprecated codefresh_pipeline_cron_trigger resource, which has different API constraints (6 fields instead of 5)

Why

  • More DRY
  • Better package structure
  • CRON Validation fix

Notes

Checklist

@korenyoni korenyoni force-pushed the feat/validation-refactor branch from 47d34da to 2a92f73 Compare October 16, 2023 17:39
@korenyoni korenyoni marked this pull request as ready for review October 16, 2023 18:23
@korenyoni
Copy link
Contributor Author

/test

@korenyoni korenyoni merged commit 00721ed into codefresh-io:master Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants