-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Provider crashes when creating codefresh_api_key #135
Merged
ilia-medvedev-codefresh
merged 2 commits into
master
from
fix/CR-20755-crash-on-api-key-create
Feb 22, 2024
Merged
Fix: Provider crashes when creating codefresh_api_key #135
ilia-medvedev-codefresh
merged 2 commits into
master
from
fix/CR-20755-crash-on-api-key-create
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-medvedev-codefresh
requested review from
yaroslav-codefresh,
denis-codefresh and
a team
as code owners
February 21, 2024 18:17
ilia-medvedev-codefresh
changed the title
fix: Provider crashes when creating codefresh_api_key
Fix: Provider crashes when creating codefresh_api_key
Feb 21, 2024
/test |
11 similar comments
/test |
/test |
/test |
/test |
/test |
/test |
/test |
/test |
/test |
/test |
/test |
/test |
shirtabachii
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed id determination logic for api keys which caused the provider to crash
Why
Provider crashes when creating codefresh_api_key
Notes
Checklist
/test
comment will be ignored by the CI trigger unless it is made by a repo admin or collaborator.