Fix - codefresh_current_account data source returns 403 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-medvedev-codefresh
requested review from
yaroslav-codefresh,
denis-codefresh and
a team
as code owners
|
/test |
1 similar comment
|
/test |
|
/test |
korenyoni
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove unnecessary call to GetUserByID that requires admin token to get the account admins info. Instead infer admin info from /user endpoint which returns the info for all users. As admins are also users the data is there, it is enough to just locate the admins in this existing list.
Why
Closes #131
Notes
Checklist
/testcomment will be ignored by the CI trigger unless it is made by a repo admin or collaborator.