Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split client and provider into separate packages #2

Merged
merged 13 commits into from
Jun 9, 2020
Merged

Split client and provider into separate packages #2

merged 13 commits into from
Jun 9, 2020

Conversation

palson-cf
Copy link
Contributor

Overview

Create client package:

  • client.go:
    • Client struct;
    • NewClient();
  • pipeline.go:
    • Pipeline struct;
    • CRUD methods;
  • project.go:
    • Project struct;
    • CRUD methods;

@sharon-codefresh sharon-codefresh self-assigned this Jun 8, 2020
sharon-codefresh
sharon-codefresh reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@sharon-codefresh sharon-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

main.go Outdated Show resolved Hide resolved
client/pipeline.go Outdated Show resolved Hide resolved
client/utils.go Show resolved Hide resolved
codefresh/provider.go Show resolved Hide resolved
codefresh/resource_project.go Show resolved Hide resolved
codefresh/resource_pipeline.go Show resolved Hide resolved
@palson-cf palson-cf merged commit b924e06 into master Jun 9, 2020
@palson-cf palson-cf deleted the saas-7282 branch June 9, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharon-codefresh sharon-codefresh sharon-codefresh approved these changes

Assignees

@sharon-codefresh sharon-codefresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palson-cf @sharon-codefresh