Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce regex2 to support perl regex #40

Conversation

sandrogattuso
Copy link
Contributor

This PR introduces the usage of the library https://github.com/dlclark/regexp2 to support Perl regular expression.
It replaces the StringIsValidRegExp function from the Terraform validation package with a custom one that leverages the above library.
If this PR is accepted the following note in the documentation for the triggers can be removed:

When using the Terraform Provider, please use the Go regex syntax as some perl regex syntax is not compatible.

@alex-codefresh alex-codefresh merged commit 6eeaf1c into codefresh-io:master Apr 21, 2021
@sandrogattuso sandrogattuso deleted the feature/introduce-regexp2-package branch May 29, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants