Support for specifying spec.packId on codefresh pipeline
#44
Conversation
mattmelgard
force-pushed
the
feature/packid
branch
from
dd2130a to
7d21bcc
Compare
|
@alex-codefresh @vadimgusev-codefresh this is ready for review if either of you has a chance. Thanks! -- Also please let us know what the best way to request a review is in the future. |
mattmelgard
force-pushed
the
feature/packid
branch
from
7d21bcc to
823e3a6
Compare
|
@alex-codefresh @vadimgusev-codefresh please review or assign to whoever is responsible for that now. Thank you. |
|
Looks like this PR is stuck. I'm going to huddle up with the team and figure out how we can get those moving. |
|
Assigned to @ziv-codefresh |
codefresh/resource_pipeline_test.go
Outdated
| @@ -57,6 +57,7 @@ func TestAccCodefreshPipeline_Concurrency(t *testing.T) { | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.concurrency", "1"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.branch_concurrency", "2"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.trigger_concurrency", "3"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.pack_id", "5cd1746617313f468d669045"), | |||
There was a problem hiding this comment.
where are you getting this value from?
the tests passed for you locally?
you should create a new configuration test that will take this packId value as an argument and apply it.
There was a problem hiding this comment.
@todaywasawesome / @ziv-codefresh I updated the tests to what I think they should look like but I'm not entirely certain on how to run the tests. Running make test seems to pass, but a good portion of them are skipped from what I can tell and I don't really see any repo-level documentation regarding how to run them either. Let me know and thanks.
codefresh/resource_pipeline_test.go
Outdated
| @@ -71,6 +72,7 @@ func TestAccCodefreshPipeline_Concurrency(t *testing.T) { | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.concurrency", "4"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.branch_concurrency", "5"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.trigger_concurrency", "6"), | |||
| resource.TestCheckResourceAttr(resourceName, "spec.0.pack_id", "6cd1746617313f468d667048"), | |||
mattmelgard
force-pushed
the
feature/packid
branch
from
823e3a6 to
40bd8ac
Compare
|
@todaywasawesome @ziv-codefresh can we please get some support on this? Thanks. |
|
@todaywasawesome any chance we can get some updates, we'd love to get this merged in so we can continue to use the official provider. Right now this change is blocking us from doing so. |
|
I can rebase again as needed, but I need a little guidance on some things here as well. |
mattmelgard
force-pushed
the
feature/packid
branch
from
5fbc64f to
ac02e5b
Compare
|
Looks like something might have already been merged in in the most recent release that supports specifying this now. I suppose this is probably not needed anymore? |
|
@mattmelgard yeah, I was about to review your PR, but seems like this is already implemented in the latest commits. Anyway thanks for the effort, we will try pay more attention to this repo in the future. |
|
@mattmelgard Glad we could get the feature in though wish it would have gone through the PR. I think we have some improvement to make as an open source company. |
This PR adds a resource argument to the
codefresh_pipelineresource that allows aspec.packIdto be provided. This is useful to users who use the built inSAAS runtimeenvironment but who want to specify the use of aMEDIUMorLARGEresource size for that runtime environment as pictured in the UI below.Currently this is not possible and defaults to the
SMALLresource size meaning that if changes are made to a pipeline using that resource size it will be reset to theSMALLresource size upon apply.NOTE: I'm a new contributor to the repository and still rather new to Golang, so feel free to yell at me if I missed something important