fix(jobs-containers): Update deployment and jobs to support 3d tools like Vals #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixing the args of the reconcile-runtime container and the gencerts and cleanup jobs containers. Removing redundent space that cause issues when using 3d tools like Vals (helmfile/vals)
Why
There is an issue with your helm chart using 3d tools like Vals (helmfile/vals). You have an extra space which cause "mapping values are not allowed in this context" error in 3d tools reading the template result of the cf-runner helm chart.
This change fixes this bug without changing anything else.
Notes
Sorry for creating 2 different pull requests, I didn't expect you will be that fast 💪
POC:
