feat(venona): report task status to te platform #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masontikhonov
force-pushed
the
CR-25384-runner-report-status-of-task-execution-to-cf-api
branch
3 times, most recently
from
0e0dfd5 to
bf2cab0
Compare
masontikhonov
force-pushed
the
CR-25384-runner-report-status-of-task-execution-to-cf-api
branch
from
bf2cab0 to
01b3b1f
Compare
…-25384-runner-report-status-of-task-execution-to-cf-api
ATGardner
reviewed
Dec 2, 2024
venona/pkg/task/task.go
Outdated
Comment on lines
46
to
47
| // Task Id | ||
| Id string |
There was a problem hiding this comment.
i'm not sure this is needed.
the type and status have their type definitions because they behave like enums, and have a predefined set of values.
the id is just any random string, i imagine.
There was a problem hiding this comment.
Yeah, this makes sense. Will fix it now
ATGardner
reviewed
Dec 2, 2024
| return fmt.Errorf("failed marshalling when reporting task status: %w", err) | ||
| } | ||
|
|
||
| _, err = c.doRequest(ctx, "POST", bytes.NewBuffer(s), nil, "api", "agent", c.agentID, "tasks", string(id), "statuses") |
There was a problem hiding this comment.
is bytes.NewBuffer(s) needed, when s is already []byte?
maybe it is, i am not sure.
There was a problem hiding this comment.
It requires io.Reader interface, so it seems that it's needed
ATGardner
approved these changes
Dec 2, 2024
masontikhonov
force-pushed
the
CR-25384-runner-report-status-of-task-execution-to-cf-api
branch
from
9a4aee3 to
85add13
Compare
…-25384-runner-report-status-of-task-execution-to-cf-api
masontikhonov
deleted the
CR-25384-runner-report-status-of-task-execution-to-cf-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds support for reporting agent tasks statuses back to the platform.
Also, this exposes Runtime chart version to the
venonaandengine.