Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: composition v3 #529

Closed
wants to merge 2 commits into from
Closed

feat: composition v3 #529

wants to merge 2 commits into from

Conversation

mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented Nov 21, 2024 •
edited
Loading

What

Update engine. Allow service compositions version 3.0

Pipeline example

version: 1.0
services:
  version: '3.0'
  name: environment
  composition:
    mongo:
      image: 'mongo:6.0.14'
      restart: always
      ports:
        - '27017'
      command: mongod
      healthcheck:
        test:
          - CMD
          - mongo
          - '--eval'
          - db.adminCommand('ping')

steps:
  ...

Why

Notes

@mikhail-klimko mikhail-klimko marked this pull request as ready for review November 22, 2024 08:16
@mikhail-klimko mikhail-klimko requested a review from a team as a code owner November 22, 2024 08:17
masontikhonov
masontikhonov reviewed Dec 5, 2024
View reviewed changes
charts/cf-runtime/values.yaml
@@ -493,9 +493,9 @@ runtime:
image:
registry: quay.io
repository: codefresh/engine
tag: 1.174.18
tag: 1.150.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated tag

@masontikhonov
Copy link
Contributor

Was delivered here: #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masontikhonov masontikhonov masontikhonov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikhail-klimko @masontikhonov