Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve tlsSecret path #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve tlsSecret path #542

wants to merge 1 commit into from

Conversation

drewburr
Copy link

@drewburr drewburr commented Dec 6, 2024

What

Fixes path to .tlsSecret, which is described in values.yaml to exist under .ingress and is earlier used to conditionally template the tls spec

Why

Documented functionality does not match chart behavior

Notes

We are able to get around this today by defining:

appProxy:
  tlsSecret: secret-name
  tls:
    tlsSecret: secret-name

@drewburr drewburr requested a review from a team as a code owner December 6, 2024 21:16
@drewburr drewburr changed the title Fix tlsSecret path fix: resolve tlsSecret path Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drewburr