Upgrade to Rubocop 0.50.0 (fixes CVE-2017-8418) #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebolsin
force-pushed
the
security/rubocop-upgrade
branch
from
0766a16 to
9459a1a
Compare
dblock
reviewed
Oct 2, 2017
| gem 'danger-changelog', '~> 0.1' | ||
| gem 'futuroscope', github: 'codegram/futuroscope' |
There was a problem hiding this comment.
Do we really need a reference into the HEAD of futuroscope? I suspect not and i would kill the whole git_source thing?
There was a problem hiding this comment.
Looks like the latest released futuroscope version on Rubygems is 0.1.11 from February 23, 2014. And there's a bunch of commits in master since then, including Futuroscope::Pools::NoPool implementation which is used in hyperclient test suite.
|
Merged thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop versions up to 0.49.1 are affected by CVE-2017-8418 (rubocop/rubocop#4336).
Although it's a pretty minor issue, it makes Gemnasium unhappy:
This PR:
~> 0.50.0rubocop --auto-correctStyle/AsciiCommentsoffence inlib/hyperclient/collection.rb.rubocop_todo.ymlwithrubocop --auto-gen-config