Removed futuroscope #133
Merged
Removed futuroscope #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
futuroscope
branch
2 times, most recently
from
71adb44 to
bb6d631
Compare
dblock
force-pushed
the
futuroscope
branch
6 times, most recently
from
8e19b13 to
f90a92a
Compare
ivoanjo
approved these changes
Jan 5, 2018
UPGRADING.md
Outdated
| end | ||
| ``` | ||
|
|
||
| The default new behavior is synchronous. Include `futuroscope` in your `Gemfile` and wrap Hyperclient requests into `Futuroscope::Future.new` blocks when you wish to utilize this pattern. |
There was a problem hiding this comment.
May I suggest we point people at concurrent-ruby for the reasons I discussed on #123?
It's equivalent in this case is wrapping the request with Concurrent::Future.execute.
|
I wrote this. I think that's what we want. The default new behavior is synchronous. We recommend concurrent-ruby for your future asynchronous needs. Include Just hit merge if you're happy with it ;) |
|
Merging away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123.
@ivoanjo Your call to merge!