Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-paginate embedded resources, closes #106. #193

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Auto-paginate embedded resources, closes #106. #193

merged 1 commit into from
Dec 28, 2020

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Dec 2, 2020 •
edited
Loading

Implemented auto-pagination of embedded resources. This would change the default behavior and paginate through "next" links.

@dblock dblock mentioned this pull request Dec 2, 2020
Closed
@dblock
Copy link
Collaborator Author

dblock commented Dec 3, 2020

Maybe I can get a code review from @mrcasals or @yuki24? I am debating whether it's ok to introduce a full iteration over paginated resources here by default. Will merge in a bit if I don't hear back.

@dblock dblock merged commit d7924d2 into codegram:master Dec 28, 2020
@dblock dblock deleted the auto-paginate branch January 2, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dblock