-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rubocop, upgraded Faraday, removed Gemfile.lock. #61
Conversation
b621c4e
to
8561589
Compare
8561589
to
ab42327
Compare
@@ -1,5 +1,5 @@ | |||
require 'faraday' | |||
require_relative 'request/digest_authentication' | |||
require 'faraday/digestauth' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👎 on this since this gem seems a blatant rip of the actual code at hyperclient. See a47d7db and e443018#diff-05401ebefab536882f566b668412c798L2 vs bhaberer/faraday-digestauth@d41137a
Also, the gem author forgot to copy the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, actually it's a rip from https://gist.github.com/kapkaev/5088751 :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't really belong in Hyperclient and is a generically useful Faraday thing - who copies from whom is beyond the point, no? I guess I am trying to say that instead of adding this code to Hyperclient someone (you? :)) should have made a gem out of this. Looks like @bhaberer did just that (and thanks).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do let me know if you want me to undo this, though.
I made a PR into the gem acknowledging where it comes from and porting tests, bhaberer/faraday-digestauth#6.
Yea the person who posted the gist never responded to any messages so I had no idea that this came from someplace else. I'll merge that pull in a bit, and add @oriolgual as a gem author, if he wants? I'm fairly amicable to whatever. I just need/ed Faraday to speak digest. |
That seems super reasonable, thank you both :) and 👍 on this PR |
Added Rubocop, upgraded Faraday, removed Gemfile.lock.
This is a bunch of related things.