Added support for templated links with no arguments. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
handle-link-expansion
branch
from
14ca9be to
e4162ae
Compare
dblock
added a commit
that referenced
this pull request
Oct 16, 2014
Added support for templated links with no arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAL API spec don't describe what's required vs. what's not in a URI parameter. These are just URI templates per https://tools.ietf.org/html/rfc6570.
It seems incorrect to raise a
MissingURITemplateVariablesExceptionfor a templated link because you can have something like this:/orders{?page,size}. Now of course we could say any{parameter}is required and any{?parameter}is optional, but that wouldn't match the URI template RFC either.This change relaxes the requirement to specify parameters to expand a templated link, with an additional warning in the README.