Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EclipseCompiler does not respect encoding. #73

Closed
karkusviktor opened this issue May 13, 2020 · 2 comments
Closed

EclipseCompiler does not respect encoding. #73

karkusviktor opened this issue May 13, 2020 · 2 comments

Comments

@karkusviktor
Copy link

Since 2.8.6 it reads the files with default charset:

plexus-compiler/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java

Line 328 in 0df7395

Charset.defaultCharset());

Try compiling the attached file when default charset is ISO-8859-1.
Utf.java.txt
@tomaswolf
Copy link
Contributor

tomaswolf commented May 24, 2020 •
edited
Loading

As far as I see the BatchCompiler also would use the default charset. Did you mean that you'd compile this by giving the charset on the command-line? Or which charset should be used?

CompilerConfig.getSourceEncoding() needs to be used also for that StandardJavaFileManager.

tomaswolf referenced this issue in tomaswolf/plexus-compiler May 24, 2020
@tomaswolf
Issue #73: Use configured file encoding for JSR-199 Eclipse compiler
3b8bbbf 
The JSR-199 Eclipse compiler needs to have the encoding set explicitly
for its javax.tools.StandardJavaFileManager. Use the encoding configured
in the CompilerConfiguration or in the compiler arguments, and fall back
to the platform default only if none is given explicitly.
@tomaswolf tomaswolf mentioned this issue May 28, 2020
Closed
@tomaswolf tomaswolf mentioned this issue Jun 16, 2020
Merged
olamy pushed a commit that referenced this issue Jun 18, 2020
@tomaswolf
Issue #73: Use configured file encoding for JSR-199 Eclipse compiler (#…
8a7819f 
…74)

The JSR-199 Eclipse compiler needs to have the encoding set explicitly
for its javax.tools.StandardJavaFileManager. Use the encoding configured
in the CompilerConfiguration or in the compiler arguments, and fall back
to the platform default only if none is given explicitly.
@tomaswolf
Copy link
Contributor

tomaswolf commented Aug 10, 2020 •
edited
Loading

I think this can be closed.

@olamy : How about a new release? In addition to this, #78 also added support for the <release> tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slachiewicz @tomaswolf @karkusviktor