fix methods of lint and warning see https://github.com/codehaus-plexus/plexus-compiler/pull/131#discussion_r622796309

[olamy]

No description provided.

[bondolo]

The reason that the naming was a bit odd was that there was an existing showWarnings() flag. The intention was that the warnings flag would still control whether lint would be shown to avoid the weird corner case where warnings were disabled and lint was configured.
warnings enabled : show errors, warnings, and "lint"
warnings disabled : show errors only.

As proposed warnings and lint will be configured independently. This sort of makes sense for javac but will allow for the lint-but-not-warnings state. For Eclipse ecj, which has only one warnings command line flag but previously no method of giving it options, the configuration of warnings will be confusing. If you specify lint options but disable warnings then your lint options will be ignored.

For the <showLint/> usage which would enable -Xlint but provide no options I do agree that this should be possible. I am not sure if it is better to use distinguishing between null and empty string or a separate boolean flag.

[olamy]

@pzygielo ping

[pzygielo]

👍