Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a TreeSet instead of HashSet to get consistent ordering of results #352

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Use a TreeSet instead of HashSet to get consistent ordering of results #352

merged 1 commit into from
Jan 30, 2024

Commits on Jan 30, 2024

  1. Use a TreeSet instead of HashSet to get consistent ordering of results 

    Currently a HashSet is used to collect the source files, this means that
the order returned is unspecified and in the worst case even random
across machines/jvms. In some rare cases it could happen that this even
has a slight influence on the produced class files if sources are
processed in different order and therefore threat reproducible builds.

This now uses a TreeSet instead of a HashSet so the results are always
in a deterministic order using the String#compare contract.
    Christoph Läubrich committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    34ce16b View commit details
    Browse the repository at this point in the history