Close StandardJavaFileManager #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
approved these changes
Aug 23, 2020
olamy
approved these changes
Aug 23, 2020
tomaswolf
added a commit
to tomaswolf/plexus-compiler
that referenced
this pull request
Aug 24, 2020
olamy
pushed a commit
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the API contract, the
StandardJavaFileManagerisCloseableand must be closed or file handle leaks will occur.On a very large multi-module Maven project this was causing tens of thousands of open file handles and a sawtooth-shaped time series graph over open files as the GC finalizer just happened to come around and finalize the dereferenced
JarFileSystemobjects, causing them to close on their own as a stop-gap. On some machines, a "Too many open files" error was experienced, failing the build.With this change in place, the number of open files fluctuates gently as each compilation opens the files it needs and closes them as soon as it has completed. That is the expected behavior.