Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve PR workflow #6372

Merged
merged 4 commits into from
Aug 13, 2022
Merged

docs: improve PR workflow #6372

merged 4 commits into from
Aug 13, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 12, 2022

Description

  • add "If you sent to the wrong branch"
  • add optional step to back up the PR branch

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis mentioned this pull request Aug 12, 2022
Closed
5 tasks
datamweb
datamweb approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

MGatner
MGatner approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Seems a frequent need. One suggestion, take it or leave it.

contributing/workflow.md Show resolved Hide resolved
@kenjis kenjis merged commit 556178d into codeigniter4:develop Aug 13, 2022
@kenjis kenjis deleted the improve-pr-workflow branch August 13, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @datamweb @MGatner @paulbalandan