-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation custom error asterisk field #6378
Fix validation custom error asterisk field #6378
Conversation
May I rebase to solve resolve conflicts? |
Yes, please. |
Thanks, but it is not "rebase", because you added another commit. |
52758bb
to
1313060
Compare
…judge if validation fields have asterisk
1313060
to
574feb7
Compare
@kenjis I reset my git flow and re-rebase, is there the git flow show normally in this time? |
Thank you. It looks good. |
@ping-yee Please fix coding style. 1) CodeIgniter4/tests/system/Validation/ValidationTest.php (trailing_comma_in_multiline, unary_operator_spaces, not_operator_with_successor_space)
---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php
@@ -472,7 +472,7 @@
'foo' => [
['bar' => null],
['bar' => null],
- ]
+ ],
];
$this->validation->setRules(
['foo.*.bar' => ['label' => 'foo bar', 'rules' => 'required']],
@@ -481,7 +481,7 @@
$this->validation->run($data);
$this->assertSame([
'foo.0.bar' => 'Required',
- 'foo.1.bar' => 'Required'
+ 'foo.1.bar' => 'Required',
], $this->validation->getErrors());
}
----------- end diff ----------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix coding style.
@kenjis I have been fix my coding style. |
@ping-yee Thank you! |
Description
Fixes #6245
Supersedes #6352
Checklist: