Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve services.rst #6432

Merged
merged 1 commit into from
Aug 27, 2022
Merged

docs: improve services.rst #6432

merged 1 commit into from
Aug 27, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2022

Description

  • add explanation about a shared instance and parameters

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 27, 2022
@MGatner MGatner changed the title docs: imporve services.rst docs: improve services.rst Aug 27, 2022
MGatner
MGatner approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your example code makes me wish a little bit that we had a container. Just a little bit. 😅

@kenjis kenjis merged commit f160747 into codeigniter4:develop Aug 27, 2022
@kenjis kenjis deleted the fix-docs-services.rst branch August 27, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner