Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace PHP_VERSION by PHP_VERSION_ID #8618

Merged
merged 3 commits into from
Mar 12, 2024
Merged

refactor: replace PHP_VERSION by PHP_VERSION_ID #8618

merged 3 commits into from
Mar 12, 2024

Commits on Mar 11, 2024

  1. refactor: Replace PHP_VERSION by PHP_VERSION_ID 

    PHP_VERSION_ID is prefered at CodeIgniter4 repository.
    @justbyitself
    justbyitself authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    25e3a74 View commit details
    Browse the repository at this point in the history

  2. chore: add version-compare-func-call-to-constant rule 

    Add Rector rule in order to replace PHP_VERSION by PHP_VERSION_ID.
@samsonasik suggestion: codeigniter4#8619
    @justbyitself
    justbyitself authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6bcd101 View commit details
    Browse the repository at this point in the history

  3. refactor: apply cs-fix and rector

    @justbyitself
    justbyitself committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f3e5391 View commit details
    Browse the repository at this point in the history