-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix return type in BaseResult #8709
Merged
kenjis
merged 4 commits into
codeigniter4:develop
from
Pebryan354:Pebryan354/update-return-type
Apr 5, 2024
Merged
docs: fix return type in BaseResult #8709
kenjis
merged 4 commits into
codeigniter4:develop
from
Pebryan354:Pebryan354/update-return-type
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Apr 4, 2024
kenjis
reviewed
Apr 4, 2024
kenjis
added
the
bug
Verified issues on the current code behavior or pull requests that will fix them
label
Apr 4, 2024
michalsn
approved these changes
Apr 5, 2024
kenjis
reviewed
Apr 5, 2024
kenjis
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update ResultInterface
, too.
--- a/system/Database/ResultInterface.php
+++ b/system/Database/ResultInterface.php
@@ -63,8 +63,8 @@ interface ResultInterface
* @param string $type The type of result object. 'array', 'object' or class name.
* @phpstan-param class-string<T>|'array'|'object' $type
*
- * @return array|object|stdClass|null
- * @phpstan-return ($type is 'object' ? stdClass|null : ($type is 'array' ? array|null : T|null))
+ * @return array|float|int|object|stdClass|string|null
+ * @phpstan-return ($n is string ? float|int|string|null : ($type is 'object' ? stdClass|null : ($type is 'array' ? array|null : T|null)))
*/
public function getRow($n = 0, string $type = 'object');
Co-authored-by: kenjis <[email protected]>
totoprayogo1916
approved these changes
Apr 5, 2024
kenjis
approved these changes
Apr 5, 2024
@Pebryan354 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when I use the getRow function in the query builder
$this->db->table("table_name")->getWhere(["id" => $id])->getRow("name")
, it works fine, but there is a notif or warning "Expected type 'string'...."Checklist: