config: change default config for Auto Routing Improved #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
change-auto-routing-improved-config
branch
5 times, most recently
from
cd8bd92 to
5dd958e
Compare
kenjis
force-pushed
the
change-auto-routing-improved-config
branch
from
9c00f98 to
61ae88e
Compare
|
👋 Hi, @kenjis! |
Feature::$autoRoutesImproved -> true Routing::$translateUriToCamelCase -> true
kenjis
force-pushed
the
change-auto-routing-improved-config
branch
from
61ae88e to
ecfbc2f
Compare
|
|
Even if you don't change the default controller name, you must remove
the defined route `$routes->get('/', 'Home::index');`.
|
I have made a few improvements. |
datamweb
reviewed
Jun 25, 2024
| Examples of Controller Names | ||
| **************************** | ||
|
|
||
| This is an valid controller name. Because ``App\Controllers\HelloWorld`` is CamelCase. |
There was a problem hiding this comment.
Honestly, I didn't like using 'This is', it made the review difficult for me.
There was a problem hiding this comment.
I changed to The following is.
|
|
||
| 1. The first segment represents the controller **class** that should be invoked. | ||
| 2. The second segment represents the class **method** that should be called. | ||
| 3. The third, and any additional segments, represent any **parameters** that will be passed to the controller. |
There was a problem hiding this comment.
I took from this sentence that the parameters are sent to the controller.
But the parameters are sent to the methods in the controller.
There was a problem hiding this comment.
Changed to the controller method.
|
I think it's worth adding a note about Filters. |
|
@neznaika0 Added. |
neznaika0
approved these changes
Jun 25, 2024
michalsn
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #8980
Description
Feature::$autoRoutesImproved-> trueRouting::$translateUriToCamelCase-> trueChecklist: