Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add phpstan-strict-rules #836

Merged
merged 4 commits into from
Sep 15, 2023
Merged

chore: add phpstan-strict-rules #836

merged 4 commits into from
Sep 15, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 15, 2023 •
edited
Loading

Description

  • add phpstan-strict-rules
  • enable rules
    • disallowedLooseComparison: true
    • booleansInConditions: true
    • disallowedConstructs: true
    • matchingInheritedMethodNames: true
  • update baseline

Ref codeigniter4/CodeIgniter4#7916

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis merged commit df8c1d4 into codeigniter4:develop Sep 15, 2023
29 checks passed
@kenjis kenjis deleted the add-phpstan-strict-rules branch September 15, 2023 04:36
@datamweb datamweb mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan