Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-br] update Portuguese translations #422

Merged
merged 4 commits into from
Dec 24, 2023

Conversation

xmacaba
Copy link
Contributor

@xmacaba xmacaba commented Dec 12, 2023

Added Errors.php and Language.php files with respective translations and also completed all the missing fields listed in the translation status.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Added Errors.php and Language.php
@kenjis
Copy link
Member

kenjis commented Dec 12, 2023

You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin.

This is not just a "signed-off-by" commit, but instead, a digitally signed one.

See Contribution signing for details.

Added Errors.php and Language.php files with respective translations and also completed all the missing fields listed in the translation status.
@xmacaba xmacaba closed this Dec 13, 2023
@xmacaba xmacaba reopened this Dec 13, 2023
@kenjis
Copy link
Member

kenjis commented Dec 14, 2023

There are still missing translation items.

1) Translations\Tests\BrazilianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "pt-BR" ('pt-BR')
Failed asserting that the language keys "HTTP.invalidJSON", "HTTP.unsupportedJSONFormat" in the main repository are included for translation in "pt-BR" locale.
Failed asserting that an array is empty.

https://github.com/codeigniter4/translations/actions/runs/7196029115/job/19621489927?pr=422

@kenjis
Copy link
Member

kenjis commented Dec 14, 2023

And coding style error.

   1) Language/pt-BR/Language.php (single_blank_line_at_eof)
      ---------- begin diff ----------
--- /home/runner/work/translations/translations/Language/pt-BR/Language.php
+++ /home/runner/work/translations/translations/Language/pt-BR/Language.php
@@ -12,4 +12,4 @@
 // "Language" language settings
 return [
     'invalidMessageFormat' => 'Formato de mensagem inválido: "{0}", Argumente: "{1}"',
-];
\ No newline at end of file
+];

      ----------- end diff -----------

   2) Language/pt-BR/HTTP.php (binary_operator_spaces)
      ---------- begin diff ----------
--- /home/runner/work/translations/translations/Language/pt-BR/HTTP.php
+++ /home/runner/work/translations/translations/Language/pt-BR/HTTP.php
@@ -58,9 +58,9 @@
     'disallowedAction' => 'A ação que você solicitou não é permitida.',
 
     // Uploaded file moving
-    'alreadyMoved' => 'O arquivo enviado já foi movido.',
-    'invalidFile'  => 'O arquivo original não é um arquivo válido.',
-    'moveFailed'   => 'Não foi possível mover o arquivo {0} para {1} ({2})',
+    'alreadyMoved'       => 'O arquivo enviado já foi movido.',
+    'invalidFile'        => 'O arquivo original não é um arquivo válido.',
+    'moveFailed'         => 'Não foi possível mover o arquivo {0} para {1} ({2})',
     'uploadErrOk'        => 'O upload do arquivo foi realizado com sucesso.',
     'uploadErrIniSize'   => 'O arquivo "%s" excede a diretiva ini upload_max_filesize.',
     'uploadErrFormSize'  => 'O arquivo "%s" excede o limite de upload definido em seu formulário.',

      ----------- end diff -----------

https://github.com/codeigniter4/translations/actions/runs/7196029120/job/19621585051?pr=422

@kenjis
Copy link
Member

kenjis commented Dec 14, 2023

Run the following command to check and fix the coding style:

$ bin/test pt-BR

@paulbalandan
Copy link
Member

@xmacaba are you still willing to finish this PR?

@xmacaba
Copy link
Contributor Author

xmacaba commented Dec 22, 2023

@xmacaba are you still willing to finish this PR?

yes, I'm working on it right now.. First timer.. hehe

@paulbalandan paulbalandan changed the title pt-BR Update [pt-br] update Portuguese translations Dec 24, 2023
@paulbalandan paulbalandan merged commit cd83163 into codeigniter4:develop Dec 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants