Patches from SolveSpace #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old value was likely a copy-paste error.
QCad doesn't display any dimensions where it's set.
In principle there's an algebraic relationship between the DXF line width value and line thickness in millimeters, and everything except AutoCAD accepts any value from the range, but AutoCAD ignores all values except a few chosen ones.
This forced API consumers to implement a lot of useless empty functions for no good reason.
These are all in our default implementation of DRW_Interface, which ignores everything it receives, so it's OK.
This caused a double free when deallocating DRW_Hatch.
It's more trouble than it's worth when supporting Windows. Instead, require the caller to always use the appropriate overload of std::[io]fstream constructor (possibly the wchar_t* one).
This makes polylines readable in AutoCAD again.
According to documentation $TDCREATE has code 40 and contains "Local date/time of drawing creation (see “Special Handling of Date/Time Variables”)".
When saving in the AC1006 format, several DIMSTYLE groups were erroneously omitted.
Some standards mandate the default layer to be unused.
Before, the layer was hardcoded to "0" in the writer.
Found via codespell and grep
Found via `codespell`
Having a user-specified assignment operator but default copy-constructor violates rule of 2/3/5/0. Found by clazy.
getExtrusion and getName was missing const qualifiers.
Dimension entities support DXF codes 210, 220, 230 and and DRW_Dimension already had a extPoint member, but the tags were never used when parsing.
Closed
This was referenced Jan 2, 2022
rpavlik
commented
Jan 2, 2022
| void setExtrusion(const DRW_Coord p) {extPoint =p;} | ||
| std::string getName(){return name;} /*!< Name of the block that contains the entities, code 2 */ | ||
| std::string getName() const {return name;} /*!< Name of the block that contains the entities, code 2 */ |
There was a problem hiding this comment.
this could actually be the following: std::string const& getName() const {return name;} which would allow avoiding an unneeded copy in many use cases
|
I'll merge this if passing checks on GitHub Actions. |
|
Did the tests pass in the meantime ? :) |
|
The tests did not pass, so this change has been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SolveSpace has been using this lib for quite a while, and has made some fixes. I've rebased it onto your tree and trimmed them, you might find these useful. Is there an automated test system we could verify these with, or what is your test procedure?