Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable php 8 #37

Merged
merged 7 commits into from
Oct 31, 2020
Merged

Enable php 8 #37

merged 7 commits into from
Oct 31, 2020

Conversation

malukenho
Copy link
Member

No description provided.

@malukenho
Update dependencies to make it work w/ composer 2
8614ce3 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
$ ./vendor/bin/phpcbf
4e79fbf 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Enable PHP 8
05e1987 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Run CI for the latest PHP version
2e0efbb 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Ignores .phpunit.result.cache
10ee761 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
composer req malukenho/mcbumpface --dev
488e6a6 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho malukenho added the enhancement New feature or request label Oct 30, 2020
@malukenho malukenho requested a review from EHER October 30, 2020 17:01
@malukenho
Add sponsor button
bfd1f06 
Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho malukenho added this to the 0.1.3 milestone Oct 30, 2020
airtonzanon
airtonzanon approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@airtonzanon airtonzanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a question regards running infection, psalm and cs only for the latest version of PHP, why that?

@malukenho
Copy link
Member Author

@airtonzanon Thank you for reviewing 😊

To summarise what I think about it:

  • PHPCS does not run any of our code because it works with token analyses, so there will be no difference if we run it on any of these listed versions, I choose to run in the latest one so we can have feedback on the language state and integration with the tools.

  • Psalm is the same, it is not a run-time tool, instead, it does checks and static analyses on code, but never runs the actual code itself.

  • Infection, however, does run our code, but as we are running the tests for all environments, we don't need to get coverage for all the versions here as mutations will be the same.

@malukenho malukenho merged commit a0c7083 into master Oct 31, 2020
@malukenho malukenho deleted the enable-php-8 branch October 31, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airtonzanon airtonzanon airtonzanon approved these changes

@EHER EHER Awaiting requested review from EHER

Assignees

@EHER EHER

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@malukenho @airtonzanon @EHER