Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fancy output for cli #53

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add fancy output for cli #53

merged 1 commit into from
Nov 18, 2020

Conversation

malukenho
Copy link
Member

We may move it to another repository once we decouple the output formatter.

@malukenho malukenho added this to the 1.0.0 milestone Nov 16, 2020
@EHER
Copy link
Contributor

EHER commented Nov 17, 2020

Should adhocore/cli-syntax required instead of required-dev?

@EHER
Copy link
Contributor

EHER commented Nov 17, 2020

Not related but maybe staabm/annotate-pull-request-from-checkstyle should also required instead of required-dev.

@EHER
Copy link
Contributor

EHER commented Nov 17, 2020

Looks really good! Will be awesome to have output as plugins! ❤️

image

@malukenho
Copy link
Member Author

I've changed it again. So we don't need any external tools (e.g. for highlight).
I will see if we can backport it to older versions as well.

@malukenho
Copy link
Member Author

image

@malukenho malukenho linked an issue Nov 18, 2020 that may be closed by this pull request
Improve Stdout Formatter #28
Closed
3 tasks
@malukenho @EHER
Improve standard output format
c111e03 
Heavily inspired on rust errors output.

Reviewed-by: Alexandre Eher <[email protected]>
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho malukenho merged commit 7e4405c into 1.0.x Nov 18, 2020
@malukenho malukenho deleted the clear branch November 18, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EHER EHER EHER approved these changes

@airtonzanon airtonzanon Awaiting requested review from airtonzanon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Improve Stdout Formatter
2 participants
@malukenho @EHER