Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import xulieta-plugin-installer into the project #90

Merged
merged 8 commits into from
Feb 23, 2022
Merged

Import xulieta-plugin-installer into the project #90

merged 8 commits into from
Feb 23, 2022

Conversation

EHER
Copy link
Contributor

@EHER EHER commented Feb 3, 2022

This is importing the required files from
the other project
so the functionality of autoconfigure plugins
come out of the box installing xulieta.

@EHER EHER requested a review from malukenho February 3, 2022 01:49
@EHER EHER self-assigned this Feb 3, 2022
@EHER EHER marked this pull request as ready for review February 3, 2022 01:57
@EHER EHER force-pushed the plugin-installer branch 4 times, most recently from 86801b7 to 0f7d391 Compare February 3, 2022 03:10
@EHER
Import xulieta-plugin-installer into the project
f85cb34 
This is importing the required files from
[the other project][xulieta-plugin-installer]
so the functionality of autoconfigure plugins
come out of the box installing xulieta.

[xulieta-plugin-installer]: https://github.com/codelicia/xulieta-plugin-installer

Signed-off-by: 💻 Eher <[email protected]>
@EHER EHER force-pushed the plugin-installer branch from 0f7d391 to f85cb34 Compare February 3, 2022 03:33
@malukenho
Copy link
Member 

> Codelicia\Xulieta\AutoPlugin\Register::scan
PHP Fatal error:  Uncaught TypeError: Codelicia\Xulieta\AutoPlugin\Register::scan(): Argument
 #1 ($event) must be of type Composer\Installer\PackageEvent, Composer\Script\Event given,
 called in phar:///usr/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php 
on line 389 and defined in /home/runner/work/xulieta/xulieta/src/AutoPlugin/Register.php:51

The plugin manager part is actually ahead of its time. PHP version is still old on Xulieta's main package.

@malukenho
Copy link
Member

Linking #86
Maybe we can bump the PHP version to 8.1

@malukenho malukenho linked an issue Feb 3, 2022 that may be closed by this pull request
Support PHP 8.1 #86
Closed
@malukenho malukenho added the enhancement New feature or request label Feb 3, 2022
@malukenho malukenho added this to the 1.0.0 milestone Feb 3, 2022
This was linked to issues Feb 3, 2022
Auto enable plugins when composer install|req #64
Closed
Xulieta plugins #32
Closed
@malukenho
Fix config file path
5d457c5 
Signed-off-by: Jefersson Nathan <[email protected]>
malukenho
malukenho reviewed Feb 5, 2022
View reviewed changes
@malukenho
Update dependencies
e319668 
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Update message with encoded special chars
61c0982 
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho
Allow php 8.1 on our pipeline
4d6fdcf 
Signed-off-by: Jefersson Nathan <[email protected]>
@malukenho malukenho merged commit edbf2b5 into 1.0.x Feb 23, 2022
@malukenho
Copy link
Member

We're almost there! 🍰

@malukenho malukenho deleted the plugin-installer branch February 23, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malukenho malukenho malukenho left review comments

Assignees

@EHER EHER

Labels
enhancement New feature or request
Projects
Codelicia Automated Kanban
Archived in project
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Support PHP 8.1 Auto enable plugins when composer install|req Xulieta plugins
2 participants
@EHER @malukenho