-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce continuous delivery #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `aws-cdk` and `aws-cdk-lib` are bumped to the version 2.28.1. - `constructs` is bumped to the version 10.1.42.
- A new local package `cdk-common` that collects types and functions shared among CDK stacks in this repository is introduced. It provides the type `DeploymentStage` so far. - A new CDK stack for continuous delivery is going to be introduced, and it will share some stuff like `DeploymentStage` with the CDK stack in the `cdk` folder. - `cdk-common` is supposed to be locally linked from other projects with `npm link --save ../cdk-common`. There was an issue with the `prepare` life cycle script that no dependencies of `cdk-common` were installed before running the `prepare` script and the `prepare` script ended up with a build error. The `scripts/prepare.js` script circumvents this situation by invoking `npm install` if there is no `node_modules` folder in this project. See comments in `script/prepare.js` for more details. issue codemonger-io#4
- The `cdk-common` package is locally linked with `npm link --save ../cdk-common`. issue codemonger-io#4
- `DeploymentStage` and related functions are replaced with the ones defined in `cdk-common`. issue codemonger-io#4
- `README.md` briefly explains this library. issue codemonger-io#4
- `cdk-common` is linked. - `aws-cdk` and `aws-cdk-lib` are bumped to 2.28.1. - `constructs` is bumped to 10.1.42. issue codemonger-io#4
- The CDK stack is renamed to `codemonger-operation`. issue codemonger-io#4
- `@aws-sdk/client-cloudformation` is installed so that the CDK script can obtain outputs from the main stacks. issue codemonger-io#4
- A new CDK construct `ContentsPipeline` that provisions a CodePipeline pipeline that automates the workflow to update the contents of the codemonger website is introduced. - A new CDK construct `CodemongerResources` that resolves resources in the main codemonger stacks is defined in a new file `lib/codemonger-resources.ts`. The file `lib/codemonger-resources.ts` also provides a function `resolveCodemongerResourceNames` that resolves the resource names in the main codemonger stacks by obtaining outputs from the stacks. `bin/cdk-ops.ts` invokes `resolveCodemongerResourceNames` and passes results to the constructor of `CdkOpsStack`. - You have to prepare an untracked file (in `.gitignore`) `lib/github-connection-config.ts` that provides information to connect the pipeline and this GitHub repository. issue codemonger-io#4
- `README.md` and `README.ja.md` explain how to deploy this CDK stack. They also provide the following information, - About the workflow to be automated - Why exports of CloudFormation are not used issue codemonger-io#4
- `node_modules` folders are generally ignored by git.
- `README.md` and `README.ja.md` explain what we have to do when we update the library. issue codemonger-io#4
- `package.json`, `package-lock.json`, and `service.js` are delete because they are no longer necessary.
- `README.md` and `README.ja.md` add a link to the subfolder `cdk-ops`. issue codemonger-io#4
- Links in `README.md` and `README.ja.md` are fixed.
- Meaningless `test/cdk-ops.test.ts` is deleted.
kikuomax
commented
Jun 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have self-reviewed the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new folder
cdk-ops
defines a new CDK stack that provisions AWS CodePipeline pipeline for continuous delivery. The pipeline automates the workflow to release the contents of the codemonger website.A new folder
cdk-common
will define common types and functions shared amongcdk
andcdk-ops
stacks.DeploymentStage
is moved fromcdk
tocdk-common
. This folder is linked fromcdk
andcdk-ops
bynpm link --save ../cdk-common
.The following files in the root directory are deleted because they are no longer necessary,
package.json
package-lock.json
service.js
close #4