Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart questions #914

Closed
paolomainardi opened this issue Aug 16, 2019 · 14 comments
Closed

Helm chart questions #914

paolomainardi opened this issue Aug 16, 2019 · 14 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@paolomainardi
Copy link
Contributor

Hi everyone and thanks for your hard work guys, the project is amazing.

As in the subject, i am developing an helm chart to contribute the project and i have some questions, let me start with the simplest one:

Do you see any contraindication to mount the persistence storage on /home/coder rather than the default path you suggest /home/coder/project ?

@paolomainardi paolomainardi added the enhancement Some improvement that isn't a feature label Aug 16, 2019
@deansheather
Copy link
Member

Thanks for working on a helm chart to contribute to the project! I don't have much experience with Kubernetes or Helm, but is there something wrong with the current deployment file we have included in the repository?

@paolomainardi
Copy link
Contributor Author

Hi Dean!

Nothing bad with that deployment file but as you can see everything is hardcoded, Ingress, persistence and security missing as well, all the aspect I want to cover with the helm chart, simpler to install and to adapt just by passing user’s custom vaiues.

@deansheather
Copy link
Member

In that case then, feel free to open a PR replacing the old chart. For the project storage, I'd recommend using /home/coder/project for consistency with the Docker image and possibly other deployment methods.

@paolomainardi
Copy link
Contributor Author

Ok thanks

paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 18, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 18, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 18, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 18, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 19, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 19, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 19, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 19, 2019
paolomainardi added a commit to paolomainardi/code-server that referenced this issue Aug 20, 2019
deansheather added a commit that referenced this issue Aug 20, 2019
@sr229
Copy link
Contributor

sr229 commented Sep 18, 2019

I think we @deansheather and @MichaelDesantis has worked already on this so I'll be closing this off.

@sr229 sr229 closed this as completed Sep 18, 2019
@InsOpDe
Copy link

InsOpDe commented Jan 7, 2020

What happened to the chart?
Edit: Is there a chart planned for v2?

@paolomainardi
Copy link
Contributor Author

@InsOpDe it's my question too :)

@MnrGreg
Copy link

MnrGreg commented Aug 26, 2020

Where does one find the helm chart now?

@nhooyr
Copy link
Contributor

nhooyr commented Aug 26, 2020

No plans for a helm chart at the moment.

Is the docker container not enough?

@paolomainardi
Copy link
Contributor Author

Not enough of course, to deploy it on K8s cluster.
But the question is, why the one I contributed has been removed ?

@PirateBread
Copy link

Hopefully not because extending this solution to be more useful steps on the toes of the enterprise paid version.

@nhooyr
Copy link
Contributor

nhooyr commented Aug 27, 2020

Hopefully not because extending this solution to be more useful steps on the toes of the enterprise paid version.

Not at all!

We only removed all these configs (k8s, helm, aws etc.) as no one was maintaining them in favour of a streamlined guide/docs.

However, given the demand within the issue tracker for these configs, we were obviously wrong and I've created #2012 to rectify this.

@alexgorbatchev
Copy link

Came here looking for a chart as well.

@oliverkane
Copy link

Just wanted to comment that I found this issue while looking for an official chart. Will be watching this. Curious how folks are interested in using it in k8s, as I could try my hand at putting something together for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

9 participants