Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a styling issue on iOS/iPadOs #2248

Closed
wants to merge 2 commits into from
Closed

Fix a styling issue on iOS/iPadOs #2248

wants to merge 2 commits into from

Conversation

jw-12138
Copy link
Contributor

Related issue: #2247

So, instead of using button elements( including input[type="submit"]) directly on page, I added a label element which preserved the style while remaining the same functionality.

Before

image

After

image

Over all, not a big problem but still, an improvement.

@nhooyr
Copy link
Contributor

nhooyr commented Nov 19, 2020

Hi @jw-12138, thanks for reporting this bug and contributing. ❤️

I've opened #2339 with your commit included for credits and a simpler fix applied where we just disable webkit's native input styles.

@nhooyr nhooyr closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants