Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip heartbeat on /healthz endpoint #2332

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Skip heartbeat on /healthz endpoint #2332

merged 1 commit into from
Nov 18, 2020

Conversation

code-asher
Copy link
Member

I managed to lose this in the rewrite.

Fixes #2327.

I managed to lose this in the rewrite.

Fixes #2327.
@code-asher code-asher requested a review from nhooyr as a code owner November 18, 2020 16:40
@code-asher code-asher merged commit 037a0e0 into v3.7.1 Nov 18, 2020
@code-asher code-asher deleted the healthz-heartbeat branch November 18, 2020 18:15
@code-asher
Copy link
Member Author

Wow I'm dumb I merged into the 3.7.1 branch. 🤦

@code-asher code-asher restored the healthz-heartbeat branch November 18, 2020 18:16
code-asher added a commit that referenced this pull request Nov 18, 2020
@code-asher code-asher deleted the healthz-heartbeat branch November 18, 2020 18:19
@code-asher
Copy link
Member Author

Gonna do a little force push on 3.7.1 to remove that commit. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 3.7.1 never set code-server status as expired (/healthz)
2 participants