Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): write npm package name to file #5049

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 30, 2022

Accidentally removed the part that writes the jq change to the package.json which means we weren't actually publishing to @coder/code-server-pr. Oops.

Fixes N/A

@jsjoeio jsjoeio self-assigned this Mar 30, 2022
@jsjoeio jsjoeio requested a review from a team March 30, 2022 22:31
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Mar 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 30, 2022

✨ code-server docs for PR #5049 is ready! It will be updated on every commit.

@jsjoeio jsjoeio added this to the April 2022 milestone Mar 30, 2022
@jsjoeio jsjoeio temporarily deployed to npm March 30, 2022 22:35 Inactive
@github-actions
Copy link

github-actions bot commented Mar 30, 2022

✨ code-server dev build published to npm for PR #5049!

  • Last publish status: success
  • Commit: 60bcb98

To install in a local project, run:

npm install @coder/code-server-pr@5049

To install globally, run:

npm install -g @coder/code-server-pr@5049

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #5049 (60bcb98) into main (d5d7c51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5049   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d7c51...60bcb98. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm March 30, 2022 22:56 Inactive
@code-asher code-asher merged commit 0fceb12 into main Mar 30, 2022
@code-asher code-asher deleted the jsjoeio/fix-npm-jq branch March 30, 2022 23:11
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants