Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update prettier and doctoc #5605

Merged
merged 12 commits into from
Oct 13, 2022
Merged

refactor: update prettier and doctoc #5605

merged 12 commits into from
Oct 13, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 29, 2022 •
edited
Loading

This PR refactors our prettier and doctoc tasks.

@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

✨ code-server docs for PR #5605 is ready! It will be updated on every commit.

@jsjoeio jsjoeio self-assigned this Sep 29, 2022
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:15 Inactive
@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5605!

  • Last publish status: success
  • Commit: d00d3ea

To install in a local project, run:

npm install @coder/code-server-pr@5605

To install globally, run:

npm install -g @coder/code-server-pr@5605

@codecov
Copy link

codecov bot commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #5605 (d00d3ea) into main (d4707d1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5605   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          30       30           
  Lines        1678     1678           
  Branches      366      366           
=======================================
  Hits         1217     1217           
  Misses        398      398           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4707d1...d00d3ea. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:30 Inactive
@jsjoeio jsjoeio mentioned this pull request Sep 29, 2022
Closed
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:34 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:40 Inactive
@jsjoeio jsjoeio changed the title jsjoeio/prettier fixes refactor: update prettier and doctoc Sep 29, 2022
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:46 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 23:55 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 30, 2022 01:17 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 30, 2022 20:45 Inactive
@jsjoeio
docs: add toc to CODE OF CONDUCT
f18a86d
@jsjoeio
chore: add prettier ignore blocks to docs
dade3dd
@jsjoeio
chore: update styles for Dockerfile
4827f81
@jsjoeio
refactor: separate prettier, doctoc
9825c13 
This does a couple things:
- update `.prettierignore`
- split `prettier` and `doctoc` commands. you can still run with `yarn
  fmt`
- delete `fmt.sh` and add `doctoc.sh`

By doing so, we can run tasks in parallel in CI and we should also have
less false positives than before with `yarn fmt` locally.
@jsjoeio
refactor: update prettier job, add doctoc
d8c6c01 
This modifies the prettier job to use actionsx/prettier. It also adds a
job for `doctoc`.
@jsjoeio jsjoeio force-pushed the jsjoeio/prettier-fixes branch from 75184c9 to d8c6c01 Compare September 30, 2022 20:59
@jsjoeio jsjoeio temporarily deployed to npm September 30, 2022 21:02 Inactive
jsjoeio
jsjoeio commented Sep 30, 2022
View reviewed changes
.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
docs/guide.md Show resolved Hide resolved
docs/guide.md Show resolved Hide resolved
@jsjoeio jsjoeio marked this pull request as ready for review September 30, 2022 21:03
@jsjoeio jsjoeio requested a review from a team as a code owner September 30, 2022 21:03
code-asher
code-asher approved these changes Oct 4, 2022
View reviewed changes
ci/release-image/Dockerfile Show resolved Hide resolved
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 4, 2022

I want to make a couple minor changes so converting to draft

@jsjoeio jsjoeio marked this pull request as draft October 4, 2022 19:03
@jsjoeio jsjoeio temporarily deployed to npm October 4, 2022 19:06 Inactive
@jsjoeio jsjoeio temporarily deployed to npm October 10, 2022 21:52 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review October 10, 2022 21:55
@jsjoeio jsjoeio requested a review from code-asher October 10, 2022 21:56
@jsjoeio jsjoeio temporarily deployed to npm October 10, 2022 22:00 Inactive
@jsjoeio jsjoeio enabled auto-merge (squash) October 13, 2022 22:03
@jsjoeio jsjoeio temporarily deployed to npm October 13, 2022 22:06 Inactive
@jsjoeio jsjoeio merged commit 71a127a into main Oct 13, 2022
@jsjoeio jsjoeio deleted the jsjoeio/prettier-fixes branch October 13, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher